less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
17.02k stars 3.41k forks source link

Resolve #3398 Add flag to disable sourcemap url annotation #3517

Closed hirosato closed 4 years ago

hirosato commented 4 years ago

Small doubts Shall I use positive form for the property? I mean using appendSourcemapUrlAnnotation, for example, instead of disableSourcemapAnnotation sounds more straightforward for me. In other words, disableSourcemapAnnotation: false/true looks a little bit confusing. --source-map-no-annotation, on the other hand, looks ok for me since it does not have true/false value with it.

matthew-dean commented 4 years ago

"Disable" seems ok since having the annotation present by default is the intuited (default) behavior.

hirosato commented 4 years ago

"Disable" seems ok since having the annotation present by default is the intuited (default) behavior.

I get it. thank you for review and comment.