search

less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
17.02k stars 3.41k forks source link

Remove deprecated `request` package #3524

Closed sigv closed 4 years ago

sigv commented 4 years ago

Running

npm install less@3.11.3

produces

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

Request’s Past, Present and Future describes Node.js ecosystem has changed since the package's inception, and that it is expected by the package maintainers to slowly fade out of existence and over to a memory of a legacy stack. The package should be removed from the dependencies list.

sigv commented 4 years ago

Taking a closer look at current state, efb76ec8250f6f7e83d060a461456b829445e14b removed request@^2.83.0.

It did however also add native-request@^1.0.5, but as comparing the validity of external helper dependencies to implementing the logic in-package is outside of the scope of this issue, I will be closing this then.