search

less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
17.02k stars 3.41k forks source link

Fix `currentFileInfo` and `index` properties on nodes #3602

Closed bjpbakker closed 3 years ago

bjpbakker commented 3 years ago

These fields are accessed by other tools such as parcel (for resolving local asset URLs). As per 257efdd6884268af27beaceda467fd3a4aea5e08 the behavior with (at least) parcel for relative paths in sub-directries changed. Prior to that commit (last release 3.12.2) assets were resolved relative to the less module that contains the url(..). From release 3.13.0 parcel resolves assets relative to the root less module, because no currentFileInfo is available.

This is caused by tree nodes setting their prototype to an instance of Node. This leaves the self reference in Nodes constructor pointing to the prototype, not the actual instance the data is set on. Replacing this with properties defined on Nodes prototype fixes this.

matthew-dean commented 3 years ago

Makes sense, have you tested with Less 4 to see if it has this issue?

bjpbakker commented 3 years ago

Makes sense, have you tested with Less 4 to see if it has this issue?

Yes, I actually discovered this in 4.1.1, verified it's also on master, then traced it back to 3.13.0. This patch works for master, didn't test any older releases. But if you like to fix this in another 3.x release I'm happy to backport it.

matthew-dean commented 3 years ago

Sounds good, thanks!