search

less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
17.02k stars 3.41k forks source link

Should we update to 4.1.2? #3653

Closed nring closed 3 years ago

nring commented 3 years ago

@matthew-dean I noticed that Less 4.1.2 is up on NPM, but the GitHub releases page still only lists 4.1.1. Furthermore, not all of the CI tests for 4.1.2 completed successfully.

matthew-dean commented 3 years ago

@nring the failing test, to my knowledge, is because Node changed its error format in the latest Node, so there's a string compare failing, but there's nothing wrong in terms of functionality.

@iChenLei correct?

iChenLei commented 3 years ago

@matthew-dean yes. PR https://github.com/less/less.js/pull/3652 to fix it

iChenLei commented 3 years ago

@matthew-dean So update the github releases ?

nring commented 3 years ago

Thanks for the background on the issue. Is there a plan to release 4.1.3 with the CI fix or will this be the final release for a while.

iChenLei commented 3 years ago

@nring Thanks for your advices, I will create a pr for it, need review from matthew-dean