matthew-dean
commented
2 years ago I would take a different approach. In runtime code, unused vars can probably be safely removed. In the "api" code (which is kind of defining / documenting the interface, it should probably have different ESLint rules (in an overrides section). In the case of visitors, some of the vars are there because the interface is not clearly defined, and should be. (It's attempting to document what will be passed into each method.)
So if we address all those, there should be no need to prefix vars with _
What: fix the issues about eslint error
Why: code clean
How: fix with add _ for unused args.
Checklist:
No logic change ,Just for eslint fix.