search

less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
17.02k stars 3.41k forks source link

fix: Fix https failures on macOS #3716

Closed joeyparrish closed 2 years ago

joeyparrish commented 2 years ago

The issue was traced upstream to needle, and resolved in:

Closes #3693

What: Fix macOS ECONNRESET w/ node v14+

Why: Without the upgrade to needle, some more complex less files with https inline imports can fail with ECONNRESET, specifically on macOS w/ node v14+

How: The root cause was traced to the dependency needle, and fixed there over several PRs addressing various combinations of OS and node version

Checklist:

iChenLei commented 2 years ago

Thank you. @matthew-dean Hi, sir. Please review this pr.

matthew-dean commented 2 years ago

lgtm

joeyparrish commented 2 years ago

@iChenLei, @matthew-dean, when could we expect to see this in an official release so that we can stop using a fork?

iChenLei commented 2 years ago

@matthew-dean Can we release a new version for this bugfix ?

joeyparrish commented 2 years ago

Any chance we could get an updated release for less.js so we can stop using a fork?

joeyparrish commented 7 months ago

Less v4.2.0 seems to include the fix.