search

less / less.js

Less. The dynamic stylesheet language.
http://lesscss.org
Apache License 2.0
16.99k stars 3.41k forks source link

fix: make ci work #3774

Closed iChenLei closed 1 year ago

iChenLei commented 1 year ago

What:

CI crashed, because puppeteer not work with github actions operating system (maybe due to old version chorme? I don't know).

https://github.com/less/less.js/actions/runs/3921060243/jobs/6713174574#step:8:560

Why:

CI is important for test and project maintenance.

How:

Maybe we need upgrade our test infra deps.

Checklist:

Appened

  1. mocha-headless-chrome

    mocha-headless-chrome changelog 4.0.0 PR https://github.com/direct-adv-interfaces/mocha-headless-chrome/pull/61: Update puppeteer package to 13.1.3 version. Node.js 10 is no longer supported.

But it looks like Node10 CI work as expected ?

  1. packgae lockfile version

since node16 (node18) as LTS for a long time, so I upgrade the pack-lock.json, any opinions?

iChenLei commented 1 year ago

Thanks God, all CI passed. @matthew-dean sir, I need your code review.