search

less / more

less on rails — the official LESS plugin for Ruby on Rails
http://lesscss.org
MIT License
226 stars 41 forks source link

Fixes to Rails 3 deprecation warnings #31

Open craic opened 13 years ago

craic commented 13 years ago

Hi I've fixed a couple of Deprecation warnings in Rails 3.0.1/Ruby 1.9.2 by moving the require on the controller_extension into the top-level init.rb and using Rails.env instead of RAILS_ENV.

I had to change the test_helper to fake a Rails.env method. It passes tests in Ruby 1.8.7/Rails 2.3.8 and Ruby 1.9.2/Rails 3.0.1

Hope you can merge them into the plugin

--Rob Jones

craic commented 13 years ago

I spoke too soon - the plugin works in both Ruby 1.8.7 / Rails 2.3.8 and Ruby 1.9.2 / Rails 3.0.1 and the tests pass in Ruby 1.8.7 but they crash in Ruby 1.9.2 - the issue is a Gem::LoadError

/Users/jones/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/rubygems.rb:238:in `activate': can't activate actionpack (= 2.3.8, runtime) for [], already activated actionpack-3.0.1 for

Not sure what the issue is. I am running ruby 1.9.2 under rvm.