search

lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
68 stars 76 forks source link

Prevent create endpoint from updating existing users (optional) #10

Closed maltemco closed 5 years ago

maltemco commented 5 years ago

Why?

The SCIM spec requires the create endpoint to return a 409 response if a resource already exists. OKTA requires this behavior for any SCIM integrations; this is also what their RunScope Test Suite expects.

What?

Add a configuration option to disable the "update-on-create" functionality implemented by https://github.com/lessonly/scim_rails/pull/5

Caveats

This change is no impact on existing implementations as the out-of-the box behavior remains the same. It will bring scim_rails closer to the SCIM spec.

Testing Notes

Spec coverage has been updated to test this case.

Further Reading

https://tools.ietf.org/html/rfc7644#section-3.3

maltemco commented 5 years ago

@armilam @wernull Thank you for the prompt review! Would it be possible to get a new version (0.2.1?) released at some point?

wernull commented 5 years ago

@maltemco a new version has been pushed. It also includes a bump to the Nokogiri version because GitHub alerted us to a security issue.