search

lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
68 stars 76 forks source link

update PATCH request to reprovision #2

Closed spenceralan closed 5 years ago

spenceralan commented 5 years ago

Why?

The main purpose of this Gem right now is for us to be able to integrate seamlessly with Okta over SCIM. During testing we found that Okta sends reprovision requests using the PATCH endpoint as well as deprovision requests. Because we built it to only deprovision, we need to add that functionality.

What?

What this PR adds is a check for the status during a PATCH request to pass that status along to the user record.

Caveats

This implementation of the PATCH endpoint is not SCIM compliant. Bringing the endpoint to compliance is beyond the scope of this PR.

Testing Notes

wuz commented 5 years ago

@spenceralan, unrelated to this PR, but should we get CI implemented for this branch, at least to run the tests?

spenceralan commented 5 years ago

@wuz I love the idea of implementing CI. Do you have thoughts on CI for open source projects? I think with Codeship we would have to have an account on the project to see the tests fail?