lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
68 stars 76 forks source link

Basic Groups support #48

Closed valerauko closed 2 years ago

valerauko commented 3 years ago

Why?

Support for SCIM user Groups is currently missing Closes #46

What?

Caveats

Testing Notes

I'm developing this using Okta as well so there shouldn't be anything extra to set up.

Todo

I'm planning to mark this "ready for review" once I add rspec tests and fix lint violations

Alternatives Considered

There is the option to build a more complete User association handling as outlined in #39, but I felt that's a bit too big to chew for this purpose.

wernull commented 3 years ago

@valerauko thanks for this PR! It looks like a lot of good stuff at first glance. We'll try to get to it some time this week

wernull commented 3 years ago

@valerauko sorry for the delay. Things have got a little busy and this is something we really want to put proper attention on

valerauko commented 3 years ago

No worries, take your time