search

lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
68 stars 76 forks source link

Allow the create endpoint to find and update users #5

Closed wernull closed 5 years ago

wernull commented 5 years ago

Why?

OKTA is expecting users from group assignments to be synced if they are already in Lessonly. The problem is their group endpoint uses POST for each user in the group which is the create endpoint and we were blocking that if a user was already in the system

What?

This allows a POST create action to find and update a user if they already exist by whatever is configured as the username

Caveats

There was a spec built to cover this exact scenario so it's possible they had this as something in their documentation, however, they are denying our approval because of this blocked action.

There was a second issue with group assignment attributes but I was unable to reproduce. I'm going to reach out to our advocate in OKTA and ask for more clarity

Testing Notes

Not much to test directly from the gem. Verify the specs are doing what we want and that they are passing. We will do full integration test when we update the gem in the core app

wernull commented 5 years ago

@case-eee I forgot to increment the ruby gem version so I also updated that variable name you mentioned. Could you take another peek at this