lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
70 stars 77 forks source link

SST-19672: upgrade rails to 5.2.8.1 #59

Closed nickrobertson closed 2 years ago

nickrobertson commented 2 years ago

Why?

What is the problem this PR attempts to solve, and why is it important? Fixing a bug? Explain the problem you're solving. Laying a foundation for future work? Explain how this fits into the bigger picture.

What?

What does this PR change, and how does that solve the problem noted above? Call out any related changes, and add before-and-after screenshots for UI updates.

Caveats

Are there downsides or side-effects that should be weighed against this update? Any lingering unknowns or things you can’t test without production data or traffic?

Testing Notes

Is any special setup required to test this change? Non-obvious things that should be checked?

A list of things to test:

Alternatives Considered

Were there other approaches or solutions to this problem which you considered? Why were they not chosen?

Further Reading

Were there articles or StackOverflow answers you found especially eye-opening when working on this? Slack conversation around this? Provide a link to the thread.

Merge Instructions

Please DO NOT squash my commits when merging