search

lessonly / scim_rails

SCIM Adapter for Rails.
MIT License
68 stars 76 forks source link

Allow any minor version of Rails 5 #8

Closed armilam closed 5 years ago

armilam commented 5 years ago

Why?

This gem doesn't currently have a need to prevent anyone from using Rails up to 5.2.x. In fact, we are upgrading our core app beyond Rails 5.0, so supporting higher versions of Rails will be important to us.

What?

This PR allows Rails versions up to but not including 6. It's possible this could support Rails 6, but that hasn't been tested, so we're going to keep the restriction at 5.x.x for now.

This commit also fixes a reference to the test Rakefile, which is in a different folder than originally specified.

Testing Notes

This doesn't change any functionality, so there isn't really anything to test here. Once we upgrade our app to Rails 5.1, we will need to make sure then that SCIM still works.

armilam commented 5 years ago

Whoops! I didn't realize this is a duplicate of #7. I'll help move that one forward, instead.