Fix docstrings for SimpleBase and SimpleMatrix

lessthanoptimal / ejml

A fast and easy to use linear algebra library written in Java for dense, sparse, real, and complex matrices.

https://ejml.org

565 stars 117 forks source link

Fix docstrings for SimpleBase and SimpleMatrix #154

Closed JozsefKutas closed 2 years ago

JozsefKutas commented 2 years ago

Various minor docstring fixes for SimpleBase and SimpleMatrix:

fixed SimpleBase#cols to refer to columns rather than rows
deleted paragraph referring to variable arguments which are not actually variable
added missing docstrings for SimpleMatrix float constructors
corrected a few typos

JozsefKutas commented 2 years ago

I'm not actually sure why the SimpleMatrix(int, int, boolean, double[]) constructor doesn't take varargs, while the DMatrixRMaj(int, int, boolean, double...) constructor does, but for the moment I just changed the docstring so that it would be less confusing.

lessthanoptimal commented 2 years ago

Looks good and thanks for the edits. Just that one comment on the vararg issue you pointed out.