Download filename should not be encoded

lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.

Other

510 stars 263 forks source link

Closed jg-development closed 3 years ago

jg-development commented 3 years ago

Hi, if I download a file like "fooö.zip", the filename is after download "foo%C3B6.zip". This is because of this line in the AttachmentService:

        // extract filename
        $file = substr(strrchr($attachment->content, '/'), 1);

I am not sure why the filename is extracted from the url and not from the Attachment object. If the filename would be like:

$file = $attachment->filename;

... than the file would be correct downloaded. Can somebody help me here?

jg-development commented 3 years ago

If we can change this line to:

$file = fopen($outDir.DIRECTORY_SEPARATOR.urldecode($file), 'w');

it works for me