Bearer vs Basic Authentication with token

lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.

Other

510 stars 263 forks source link

Closed jescampos closed 2 years ago

jescampos commented 2 years ago

Hi, maybe I did some bad configuration, but I just made it working changing the JiraClient.php on line 517

from: $curl_http_headers[] = 'Authorization: Bearer ' . $this->getConfiguration()->getPeronalAccessToken();
to: $curl_http_headers[] = 'authorization: Basic '. base64_encode($this->getConfiguration()->getJiraUser() . ':' . $this->getConfiguration()->getPeronalAccessToken()

lesstif commented 2 years ago

Hi @jescampos Sorry for the late reply.

You're Jira Instance looks very old version, so it doesn't support token-based authentication.

jescampos commented 2 years ago

But I'm using jira cloud.... Jira cloud is not automatically updated?

lesstif commented 2 years ago

Jira cloud is always up to date, did you set this line in the .env configuration?

TOKEN_BASED_AUTH=true

lesstif commented 2 years ago

Hi @jescampos You're right!

JIRA Cloud v3 supports Basic auth, so I fixed it.

Thank you!

jescampos commented 2 years ago

Thank you :)

nsrosenqvist commented 3 weeks ago

@lesstif This fix appears to have been reverted, why is that? I need the changes of https://github.com/lesstif/php-jira-rest-client/commit/91c754e8b18501ece07bc1dc878a056c1200bbf0 to be able to connect this way against Jira Cloud.