lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.
Other
510 stars 263 forks source link

All jira credentials should take from config, not from env #480

Open mitesh-ko opened 2 years ago

mitesh-ko commented 2 years ago

I use this package for Jira APIs but in my project requirement, we take Jira credentials from users and use their credentials on run time. Laravel provides the functionality to update config on run time. If credentials are taken from config then we can update these on run time or we can use credentials dynamically.

Please use credentials from Jira specific config file in Laravel config folder.

lesstif commented 2 years ago

Hi @miteshkothari3319 You can use the ArrayConfigurator as the alternative solution.

check out it.

mitesh-ko commented 2 years ago

Okay, this can work. But, if there a config file we not need to use config array all the time. So I feel use config instead of .env is a good idea.