lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.
Other
510 stars 263 forks source link

Allow read and write of properties #490

Closed Schrank closed 1 year ago

lesstif commented 1 year ago

Hi @Schrank, Happy new year & Thank you for your contributions.

Could you revise your PR 2 things, please?

  1. to drop the PHPDoc base annotation & to modify to property's type declaration like below.

before

/** @var string */
public $key;

after

public string $key;
  1. add example code and documentation link into README.doc
Schrank commented 1 year ago

@lesstif Happy new year! - Am I correct, that you need to wait another three weeks, before you celebrate? Or do you celebrate the "European" new year as well? Or am I totally wrong? I remember to read something about Korean New Year is not the same day as "ours" 😅

Please have a look on the changes, wether they are as you want them :-)

And thanks for this awesome lib, saved SOO much time - and was easy to extend <3

lesstif commented 1 year ago

@Schrank Korean are celebrating the European new year and the lunar new year both. :) Repeat again, Thank you for your volunteering.

Schrank commented 1 year ago

Korean are celebrating the European new year and the lunar new year both. :)

Lucky you!

Thanks for merging <3