search

lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.
Other
510 stars 263 forks source link

Add field activatedDate to Sprint #496

Closed noahmayr closed 1 year ago

noahmayr commented 1 year ago

See https://docs.atlassian.com/jira-software/REST/9.5.0/#agile/1.0/board/{boardId}/sprint

lesstif commented 1 year ago

Hi @noahmayr Thank you for your contributions. after PHP8 was released, I prefer to use the strict type to phpDoc, Could you modify all phpDoc to strict type in Sprint.php, please?

public string $activatedDate;
noahmayr commented 1 year ago

Sure, should I also add a declare(strict_types=1) to the file?

If you want to convert the whole project to more modern Php, it might make sense to look into https://github.com/rectorphp/rector

lesstif commented 1 year ago

@noahmayr Thank you for your contributions and for introducing a great PHP package. But sometimes need to use PHPDoc for the JSON serializer to work well, so I can't convert the whole project automatically.