search

lesstif / php-jira-rest-client

PHP classes interact Jira with the REST API.
Other
510 stars 261 forks source link

Set types correctly for Version class #518

Closed reinfi closed 1 year ago

reinfi commented 1 year ago

The Version class is not correctly typed.

The name property is always required and can not be null. Or I do not get it where it could be nullable, because when you create a version a name is required.

The releaseDate is nullable, you must not set a release date when you create or update a version.

I also added default values for all typed properties because Jira does not sent them all when you create a empty version with just a name.

{
"self": "redacted/rest/api/2/version/14974",
"id": "14974",
"name": "v1.2",
"archived": false,
"released": false,
"projectId": 10028
}

Last but not least, thank you for the fast fix of 5.5.1.

If you have any questions, just let me know.

reinfi commented 1 year ago

any idea when to a new version will be tagged?

lesstif commented 1 year ago

Hi @reinfi it's released as 5.6.0. Thank you!