Comparing boolean with integer

lesterchan / wp-polls

Adds an AJAX poll system to your WordPress blog. You can also easily add a poll into your WordPress's blog post/page.

https://wordpress.org/plugins/wp-polls/

93 stars 78 forks source link

Comparing boolean with integer #92

Closed jeroneemou closed 6 years ago

jeroneemou commented 7 years ago

Hi there,

https://github.com/lesterchan/wp-polls/blob/master/polls-manager.php#L34 you're comparing integer with boolean on this line and date of start cannot be edited?. Probably should be fixed.

Thanks

elkirkmo commented 6 years ago

false == 0 in php. I am unable to recreate the start date not being editable without removing the ternary operator fix. It's likely that the issue is due to your plugin not being updated to the latest version. I've submitted a pull request for the fix you suggested, but false likely isn't causing this issue.

Edit: NVM. Your comment refers to if($edit_polltimestamp === 1). You are correct, this should be updated. Sorry if I came off as a condescending dick.