Improve bare implode - Githubissues

lesterchan / wp-sweep

WP-Sweep allows you to clean up unused, orphaned and duplicated data in your WordPress. It also optimizes your database tables.

https://wordpress.org/plugins/wp-sweep/

153 stars 22 forks source link

Improve bare implode #51

Closed szepeviktor closed 6 years ago

szepeviktor commented 7 years ago

A custom builder method could

make it secure (each item sanitized and escaped) and
more readable.

// implode( '\',\'', $this->get_excluded_taxonomies() )
$this->build_sql_list( $this->get_excluded_taxonomies() )

lesterchan commented 7 years ago

Yeap I agree. Please send in a PR =D, because if it is up to me, I don't know when I will have time to look into this again lol. So busy with my day job.

szepeviktor commented 7 years ago

Notes:

implode(',', array_map('intval', $int_arr))

"('" . implode("','", array_map( 'esc_sql', $str_arr ) ) . "')"

szepeviktor commented 6 years ago

because if it is up to me, I don't know when I will have time to look into this

@lesterchan Any chance to implement it?

lesterchan commented 6 years ago

@szepeviktor fixed =)

szepeviktor commented 6 years ago

Thanks