lestergroans / salr

Automatically exported from code.google.com/p/salr
0 stars 0 forks source link

Ignoring then un-ignoring a thread marks it as read #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Ignored a thread on the forum list
2. Go into the preferences and unignored it
3. Reload the forum list, the thread will show up as read

What is the expected output? What do you see instead?
Thread reappears but doesn't show up as read.

Original issue reported on code.google.com by pca...@gmail.com on 22 Apr 2007 at 1:48

GoogleCodeExporter commented 9 years ago
Not really sure how to handle this one, have to avoid blowing away information 
for
thread's you have legitimately read.  Maybe if the thread doesn't have a 
lastpostid
or a lastreplyct and you un-ignore go ahead and delete it?  That should ensure 
that
they've never actually read it.

Original comment by pca...@gmail.com on 22 Apr 2007 at 1:51

GoogleCodeExporter commented 9 years ago
Code also just have the code ignore any threads that are marked as read but 
don't
have a lastreplyct/lastpostid.  They're technically invalid.  I'm not sure if it
makes more sense to ignore them or write up a function to check if a thread is
invalid and remove it.  That would generalize it for starring threads as well.

I think I prefer that approach, something like 
SALastReadCom.isThreadValid(threadId)
and if it's not valid it will delete it and return false.  Otherwise it returns 
true.

Original comment by pca...@gmail.com on 22 Apr 2007 at 1:55

GoogleCodeExporter commented 9 years ago
When unignoring it should check for lrcount == 0 and delete if it is, otherwise 
set
ignore to 0.

Original comment by dq5stud...@gmail.com on 22 Apr 2007 at 2:04

GoogleCodeExporter commented 9 years ago
Made toggleThreadIgnore check to see if threads had a lastReadPost before 
toggling 
ignore status.  If they exist, and there's no last read status it's an invalid 
record and gets deleted.

Original comment by pca...@gmail.com on 23 Apr 2007 at 1:39