search

lestersimjj / pe

0 stars 0 forks source link

More details on accepted argument limits in UG #12

Open lestersimjj opened 2 years ago

lestersimjj commented 2 years ago

Describe the bug
The UG should state more limitations for the arguments eg. non-negative for cost.

Expected 

The TYPE must be one of the following types: MICROPHONE, SPEAKER, STAND, CABLE. 
The COST cannot contain any symbols.
The COST must be larger than zero and lower than $10 million.
The PURCHASE_DATE must not be in the future.
The SERIAL _NUMBER must not be a repetition with the serial numbers in the current inventory.
Min. number of characters in SERIAL_NUMBER is 4. Max number of characters is 10.

Actual 

The TYPE must be one of the following types: MICROPHONE, SPEAKER, STAND, CABLE. 
The COST cannot contain any symbols.
nus-pe-script commented 2 years ago

Team's Response

With the exception of duplicate serial numbers, there are actually no constraints set on the remaining points. We do acknowledge that the serial number issue is an oversight on our part and have marked this as a duplicate of #507.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Constraint of no duplicate serial numbers not mentioned in UG

It would be helpful to indicate that duplicate serial numbers are not allowed in the UG.

image.png

[original: nus-cs2113-AY2122S2/pe-interim#594] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We indeed missed this out.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]