Open lestersimjj opened 2 years ago
The parser object is still active and will be reused in subsequent calls to the parseCommand method. Therefore the activation bar should not be broken.
Team chose [response.Rejected
]
Reason for disagreement: I disagree because there is a difference between activation and lifeline of an object. After Parser returns to Duke (arrow 1.2), the Parser object is no longer active but still alive.
Lifeline: Represents an instance being alive.
Activation: Represents the period during which a method from an element is being executed.
https://nus-cs2113-ay2122s2.github.io/website/schedule/week10/topics.html
In the Duke.java file, it can be seen that after a Parser object is instantiated, there are other lines of codes being ran, meaning that Parser would not have been active until parser.parseCommand()
is called.
Similarly, after the UpdateCommand completes its method in arrow 1.3.2, UpdateCommand should not have been active but still alive since there are no methods running in UpdateCommand at this time until command.execute()
is called in the ExecuteCommand()
function.
Describe the bug
When the parser returns to Duke (arrow 1.2), the Parser class should be broken as it is no longer active. However, in the sequence diagram it remains unbroken. The Parser class will only be active again after Duke calls the parseCommand method.
Screenshots