search

lestersimjj / pe

0 stars 0 forks source link

Maximum Limit of Item Cost #6

Open lestersimjj opened 2 years ago

lestersimjj commented 2 years ago

Describe the bug
The UG mentions the maximum item cost to be $10 million. However, a user can still add an item with cost larger than or equal to $10 million. The UG mentions that any cost larger than or equals to $10 million will not be displayed correctly, but the items are still accepted and reflects the correct number upon list command.

To Reproduce 

add n/`SpeakerA` s/`S12345` t/`Speaker` c/`10000000` pf/`Loud_Technologies` pd/`2022-02-23`
add n/`SpeakerC` s/`S7898` t/`Speaker` c/`10000001` pf/`Loud_Technologies` pd/`2022-02-23`
list

Expected Behavior
Error. Please ensure that the item cost is lower than $10 million.

Actual Behavior 

Equipment successfully added: SpeakerA, serial number S12345
Equipment successfully added: SpeakerC, serial number S7898

Screenshots

image.png

nus-pe-script commented 2 years ago

Team's Response

It did not display the price correctly as the correct shown price should be 10000000 instead of 1.0E7

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree because the response did not answer to the bug that despite an upper limit of <$10million being stated in the UG, a user is still able add an item with cost larger than or equal to $10 million.

The screenshot shows adding Speaker A that costs $10 million and adding Speaker B that costs $10.1 million. Both are accepted by the program and shown upon the list command.

image.png

image.png
Highlighted in orange.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a cosmetic issue. The program does not impose the upper limits as specified by the UG. Appears in rare situations and cause inconvenience to the manager monitoring the inventory when such cost should not have been allowed in the first place.