lestersimjj / pe

0 stars 0 forks source link

Update command should require 1 mandatory field to be updated #8

Open lestersimjj opened 2 years ago

lestersimjj commented 2 years ago

Describe the bug
A user is able to enter no arguments apart from the serial number and a success message is still returned. An error can be thrown instead.

To Reproduce

update s/`1234`

Expected Behavior
Please update at least one of the fields - type, cost, purchase from, purchase date.

Actual Behavior

Equipment successfully updated for serial number 1234,
Updated details are:

Screenshots

soc-pe-bot commented 2 years ago

Team's Response

True, we could have displayed a message to ask for at least one attribute to be updated, but this does not affect usage of the application.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

[x] I disagree

Reason for disagreement: I disagree as this is not a cosmetic issue. This is more of an error-handling issue that was not caught by the team and the program also proceeds to say that an item has been successfully updated when there were no updates.