search

lesteve / scikit-learn-tests-pyodide

Run scikit-learn test suite inside Pyodide
3 stars 1 forks source link

Update after OpenBLAS switch #12

Closed lesteve closed 1 year ago

lesteve commented 1 year ago

It seems like there are tests that got fixed by switching to OpenBLAS. The first build that used OpenBLAS is https://github.com/lesteve/scikit-learn-tests-pyodide/actions/runs/4685393646/jobs/8302457106. It failed because some tests passed and were not expected to.

The good news is that there are no fatal errors any more :tada:

rth commented 1 year ago

Very nice!

lesteve commented 1 year ago

Side-comment: the sklearn.tree.tests don't seem related to OpenBLAS and somehow they don't fail anymore after the OpenBLAS switch, not sure why, but let's call it a nice side-effect ...