lesteve / scikit-learn-tests-pyodide

Run scikit-learn test suite inside Pyodide
3 stars 1 forks source link

Running tests in CI #2

Closed rth closed 1 year ago

rth commented 1 year ago

Related https://github.com/lesteve/scikit-learn-tests-pyodide/issues/1

Edit: close #1 since this is now building scikit-learn from main.

rth commented 1 year ago

OK, yes, so indeed the Pyodide venv currently doesn't work with scipy due to https://github.com/pyodide/pyodide/issues/3186 I think.

This successfully builds the wheel for 1.1.1 , but that's not very useful since we are for now not loading it in the included test scripts (and it's the same version anyway as the one shipped by Pyodide 0.22.0a1).

For scikit-learn main branch, there is some regression with omp.h include that fails to cross-compile.

Byt anyway I agree that the first step could be looking into fixing tests for 1.1.1. I think some number of the failures would be due to https://github.com/pyodide/pyodide/issues/156

lesteve commented 1 year ago

I'll merge this one when CI is green, this is good enough to be useful.

Possible improvements: