search

lestoni / faker-cli

cli wrapper for fakerjs
Other
114 stars 10 forks source link

deps: migrate `faker` to `@faker-js/faker` #9

Closed xDivisionByZerox closed 2 years ago

xDivisionByZerox commented 2 years ago

Hello, I'm one of the members of the "new", official fork of the old faker package (now faker-js/faker).

If you are unaware of what happened to the old faker package, we have a TLDR on our website.

Since the newest version of that now deprecated faker package is corrupted we try to help people migrate away from it, so it doesn't get the traffic anymore.

Because of that, I provided a PR that updates your "old" faker package with our newest, official package.

If you have any questions or are unhappy with my implementations just leave a comment and I will adapt.

xDivisionByZerox commented 2 years ago

Thanks for merging 🙏 But seems like your build is failing. I didn't have a look in the test files, that's my bad. Do you need help with fixing the test cases?