dom.WrapNode does not implement Comment case

lestrrat-go / libxml2

Interface to libxml2, with DOM interface

MIT License

230 stars 55 forks source link

Closed bigshahan closed 7 years ago

bigshahan commented 7 years ago

Currently the WrapNode function does not implement the clib.Comment case. Is that on purpose or can I submit a PR for it?

lestrrat commented 7 years ago

PR with a test case is best :D

bigshahan commented 7 years ago

Any recommendations on how to test WrapNode. I'm not sure on how to create the input (n uintptr)

bigshahan commented 7 years ago

To add to previous comment, okay to use https://github.com/lestrrat/go-libxml2/pull/9/files as an example?

lestrrat commented 7 years ago

I'm guessing you have some code that doesn't compile or causes a runtime panic/error, so a test that reproduces that is fine. :)