'Failed to document' error message is not very meaningful

lestrrat-go / libxml2

Interface to libxml2, with DOM interface

MIT License

230 stars 56 forks source link

'Failed to document' error message is not very meaningful #54

Closed the4thamigo-uk closed 5 years ago

the4thamigo-uk commented 6 years ago

The error message 'failed to document' in the existing code doesnt mean a lot to me. How are you meant to interpret that as a user of the library?

https://github.com/lestrrat-go/libxml2/blob/master/clib/clib.go#L2203

lestrrat commented 5 years ago

Man, I've been bad by warnocking this. The error message is changed, but if it didn't give you any more context than that already, then libxml2 didn't really give us any more errors. Either I'm looking at the wrong place, or libxml2 (or the version you have) didn't report it.

Failing test cases welcome.