lestrrat-go / server-starter

Go port of start_server utility (Server::Starter)
MIT License
215 stars 21 forks source link

Feature request: signal name normalization #8

Closed harukasan closed 7 years ago

harukasan commented 7 years ago

NOTE: The PR includes the changes for #7. I will rebase these commits if #7 is done.

This PR makes allow to pass signal name variants like "SIGTERM" or "term". The original Server::Starter has the same feature.

lestrrat commented 7 years ago

I have one nitpick in that you're not testing against "term" or "TERM", but otherwise, wonderful. I will do the minor tweak myself. Thanks!

lestrrat commented 7 years ago

Actually, you ARE testing against "Hup". I guess that covers it. :D