Closed ianwilkes closed 3 years ago
Merging #26 (50bb69c) into master (09329cc) will increase coverage by
1.58%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 77.73% 79.32% +1.58%
==========================================
Files 5 5
Lines 265 266 +1
==========================================
+ Hits 206 211 +5
+ Misses 41 38 -3
+ Partials 18 17 -1
Impacted Files | Coverage Δ | |
---|---|---|
strftime.go | 86.20% <100.00%> (+2.48%) |
:arrow_up: |
appenders.go | 82.07% <0.00%> (+1.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 09329cc...50bb69c. Read the comment docs.
Nice, thanks
As discussed in issue 25, this is structurally similar to the standard library's
AppendFormat
method. I also fixed some issues withBenchmarkLestrratCachedWriter
which made it look slower than it really was.Nets about a 15% speedup which is less than I was hoping for, but still worth using in performance-intensive situations. Note the difference in the
time
output though -FormatBuffer
uses about 20% less CPU time in total for the same number of executions, probably due to reduced garbage collection overhead.