Closed ncruces closed 1 year ago
Merging #33 (4346282) into master (547681d) will increase coverage by
1.39%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 79.92% 81.31% +1.39%
==========================================
Files 7 7
Lines 274 273 -1
==========================================
+ Hits 219 222 +3
+ Misses 38 36 -2
+ Partials 17 15 -2
Impacted Files | Coverage Δ | |
---|---|---|
appenders.go | 85.98% <100.00%> (+3.57%) |
:arrow_up: |
welp. Thanks!
Hi!
I created an alternative
strftime
implementation because I needed some additional things that'd be out of scope for this. I lifted some of your tests (so thanks!) and was comparing performance, and noticed a mismatch in week number handling.This PR adds my (exhaustive) unit test and fixes it here.
Without the fix the output is:
You can validate my tests by running the following command, in macOS:
Or Linux: