search

lestrrat-p5 / DateTime-Format-Pg

Other
2 stars 5 forks source link

Patch for proper parsing of ISO datetimes. #1

Closed bacek closed 11 years ago

bacek commented 12 years ago

Hello.

I just applied patch from https://rt.cpan.org/Public/Bug/Display.html?id=51074. Can you please merge it?

Bacek

renatocron commented 8 years ago

Hello,

I'm having problems to parsing "2015-04-08T12:20:00Z", PostgreSQL accept it, but this module does not.

Found http://www.pelagodesign.com/blog/2009/05/20/iso-8601-date-validation-that-doesnt-suck/ and there's a regexp there that accept it; should I do open a new pull request, or they are wrong?

Cheers,

lestrrat commented 8 years ago

@renatocron While you may be 100% right, let's not just jump to conclusions by bringing in a regexp from a blog somewhere. Instead, please:

  1. write a test that fails
  2. If you know how to fix it: add the test and the fix, open a PR
  3. If you don't know how to fix it: add the test, and open a WIP PR

And lastly, don't comment on merged PRs :) I only stumbled upon this by accident!