zmqcheck reimplemented to improve portability

lestrrat-p5 / ZMQ

libzmq Perl binding

46 stars 31 forks source link

zmqcheck reimplemented to improve portability #55

Closed nponeccop closed 10 years ago

nponeccop commented 10 years ago

Current zmqcheck doesn't work on Windows because of multiple issues. One example is using hardcoded make instead of $Config{make} which can be either dmake or nmake on Windows.

Fortunately, a more portable and robust implementation is already present in inc/Devel/CheckLib.pm.

If this patch is accepted, whole tools/zmqcheck folder can be deleted and manifest updated.

lestrrat commented 10 years ago

Yes, I was gonna say about the Travis tests :) Glad you noticed that there are lots of yak shaving in there. I'll come back when things have settled down a bit

lestrrat commented 10 years ago

@nponeccop Can you please get rid of zmqcheck in your pull req, so the intent is clearer?