lestrrat-p5 / ZMQ

libzmq Perl binding
46 stars 31 forks source link

Fix rpath handling on macOS and test macOS on TravisCI #78

Closed zmughal closed 6 years ago

zmughal commented 6 years ago

Instead of using the entire contents of $ENV{ZMQ_LIBS}, this only uses the linker paths (-L).

Inserting the rpath was done correctly before at https://github.com/lestrrat/p5-ZMQ/commit/0b42da62f401fd1d4d83aabe9d933b517e803a98.

zmughal commented 6 years ago

The TravisCI build seems to only fail under

- { perl: "system", os: "osx", env: "PERL_ZMQ_TEST_TARGET=ZMQ-LibZMQ2" }

at the xt/102_eg_threaded.t test which hangs (when I run this locally, the test passes but only sometimes — it also hangs locally).

Should this specific build configuration be commented out in TravisCI for now?

zmughal commented 6 years ago

@lestrrat , just a reminder!

zmughal commented 6 years ago

@lestrrat, @mosconi, thoughts on this PR?