search

letakeane / emotican-app

1 stars 4 forks source link

Remove the pseudostate focus outline on buttons - closes #28 #34

Closed letakeane closed 7 years ago

letakeane commented 7 years ago

What's this PR do?

Remove the outline from the :focus pseudoselector.

Pre-Merge TODOs

Learning

Had to google to double check how to target the focus pseudoselector. Opened up the dev tools to see how :focus was styled (spoiler alert: it just has a prop of "outline".

Where should the reviewer start?

Not much to review!

Any background context you want to provide?

Screenshots (if appropriate)

Before: before, with focus outline

After: after, with transparent focus outline

Focus! FOCUS!! FOCUS!!! FOCUS!!!!

anderswood commented 7 years ago

Excellent documentation, I approve.

lauraturk commented 7 years ago

Sweet! Now I've learned how to do that too!