search

letakeane / emotican-app

1 stars 4 forks source link

Edit the text of the top button in ImageCapture - closes issue #29 #38

Closed letakeane closed 7 years ago

letakeane commented 7 years ago

What's this PR do?

Adjust the text of the top button in ImageCapture.js to read 'start camera' (to match the lowercase aesthetic of the app as a whole) instead the less clear 'Start video'.

Where should the reviewer start?

Does this text make more sense? The user doesn't necessarily think of this as a video; it's just the camera. I also hope to clarify that the user must hit the 'start camera' button before the 'take picture' button.

Screenshots (if appropriate)

Before: before

After: after

JohnBinning commented 7 years ago

That definitely looks better. It's a bit easier on the eyes with the lowercase.

Adamj1232 commented 7 years ago

That makes a lot more sense with 'camera' in the button. I would be interested to see how all letters in the button look in caps. Might work, might not....looks good as is though!

Jeff-Duke commented 7 years ago

I wonder about replacing 'start camera' with an svg of a camera? it's a pretty common pattern in video chat apps, your smart phone etc. also you might disable the 'take picture' button and have it only enable once the camera has successfully been started.

You could also look into conditionally rendering the correct button based on if the camera has been activated. so just have 'start camera' or the camera icon at first, then swap out the button once the camera promise resolves (and only if the promise resolves).

letakeane commented 7 years ago

@Jeff-Duke Conditionally rendering the different buttons in the same location is DEFINITELY my plan; I'll create a new Issue for it :)