search

letakeane / emotican-app

1 stars 4 forks source link

Error Handling #39

Open Jeff-Duke opened 7 years ago

Jeff-Duke commented 7 years ago

Currently in the <Play> and <Image Capture> components you're catching errors from your promises, one for starting the camera, one for retrieving the emotion analysis from the server but those are just being console logged. It would be good to think of the sad-path and have a way of displaying a message to the user saying that their camera couldn't be started and/or there was a problem fetching the analysis from the server etc. You could have an empty errorMessage entry in your state and update state in the catch block if an error occurs.

screen shot 2017-06-06 at 10 27 16 am

letakeane commented 7 years ago

Thanks for getting this into an Issue; it's yet another instance of something I plan on getting to but didn't write down yet.