search

letehaha / budget-tracker-fe

A web app to keep track of your finances. Track and get stats about your income, expenses and investments. WIP
https://gamanets.money
MIT License
0 stars 0 forks source link

feat: Upgrade Node and dependencies #276

Closed letehaha closed 11 months ago

letehaha commented 11 months ago

With introducing this PR we need to disable Cypress parallelization in CI because GitHub Actions is giving machines with different Chrome versions – before it worked fine, probably Cypress just didn't care about it. But from now Cypress throws errors about it.

A few workarounds:

  1. Install custom Chrome version before all the steps and pass path to it in the browser option of the Cypress CI config.. Something like that, but unfortunately it didn't work (didn't have time to check issues). https://github.com/cypress-io/github-action/issues/518#issuecomment-1210979047
  2. Use Docker container as described here. https://github.com/cypress-io/github-action/issues/518#issuecomment-1711248758. It didn't work because we rely on access to "sudo" to patch /etc/hosts. Consider changing approach with patching hosts file

Also it was not possible to bump Vite to v5 because Cypress CI was not able to find the host. See this build: https://github.com/letehaha/budget-tracker-fe/actions/runs/6914587002

cypress[bot] commented 11 months ago

Passing run #321 ↗︎

0 12 0 0 Flakiness 0

Details:

Merge b50caf5fe9e821991a3caeeb23ea77294afc33eb into e0b2ad305fa3c090a11442aff361...
Project: budget-tracker Commit: ad7ad55cc6 ℹ️
Status: Passed Duration: 01:52 💡
Started: Nov 18, 2023 2:48 PM Ended: Nov 18, 2023 2:50 PM

Review all test suite changes for PR #276 ↗︎

cypress[bot] commented 11 months ago

9 failed tests on run #322 ↗︎

9 3 0 0 Flakiness 0

Details:

feat: Upgrade Node and dependencies (#276)
Project: budget-tracker Commit: 939089d6a3
Status: Failed Duration: 09:16 💡
Started: Nov 18, 2023 2:53 PM Ended: Nov 18, 2023 3:02 PM
Failed  Accounts/Monobank/AccountAPIToken.cy.ts • 3 failed tests • Cypress tests View Output Video
Test Artifacts
Manage Monobank API token > should pair new account if not paired yet Test Replay Screenshots Video
Manage Monobank API token > should keep modal open if the request is failed Test Replay Screenshots Video
Manage Monobank API token > pair button should not exist if user already paired Test Replay Screenshots Video
Failed  SignIn.cy.ts • 2 failed tests • Cypress tests View Output Video
Test Artifacts
SignIn.cy.ts > user should be able to sign in Test Replay Screenshots Video
SignIn.cy.ts > user should see error message with invalid credentials Test Replay Screenshots Video
Failed  WelcomePage.cy.ts • 4 failed tests • Cypress tests View Output Video
Test Artifacts
Welcome page > should redirect to welcome page if base currency isn't set Test Replay Screenshots Video
Welcome page > should not be accesible if base currency is already set Test Replay Screenshots Video
Welcome page > should redirect to dashboard once base currency is set Test Replay Screenshots Video
Welcome page > should be possible to sign out from welcome page Test Replay Screenshots Video

Review all test suite changes for PR #276 ↗︎