[Issue #83] Improve preferences (Settings) layout

letelete / sleep-cycle-alarm

This app helps managing your sleep habits, so you could wake up fully rested and rock your day! Sleep cycles matter.

GNU General Public License v3.0

55 stars 21 forks source link

[Issue #83] Improve preferences (Settings) layout #89

Closed konstzv closed 5 years ago

konstzv commented 5 years ago

changed styles, dimensions
added new screens to preferences xml
changed MenuActivity to handle multiple screens
changed SettingsFragment to improve settings style

letelete commented 5 years ago

Not the exactly what I was looking for. We should have Theme and Alarm section with removed category title in it. Category title should appear instead of "Settings" title with an arrow icon instead of 'X' to let user back to the previous window (so the main settings page). We should also include the divider between the preference screens and add a little bit more space. Resizing the font size to a bigger one would be great also. Title in preferences (Settings) should have got a larger margin to the close button (X).

That's what we want:

7b9f457b-a039-4052-a349-d57d500766e8

155bcdd6-97f9-4dc7-929a-84140f691046

letelete commented 5 years ago

I can redo this PR to get the wanted effect if you want. Just give me feedback if you would like to work on this still, or should I have done that by myself? @konstzv

konstzv commented 5 years ago

I can finish it but most likely after weekends (8-9 oct). Not sure I'll be free earlier but I ll try @letelete

letelete commented 5 years ago

It's okay @konstzv, take your time! Just a quick visualization of things which should be changed (Sorry for this ugly painting instead of nice straight lines and points but just wanted to make it quick)