I replce every word in this code after i cloning it :)

lethal-guitar / RigelEngine

A modern re-implementation of the classic DOS game Duke Nukem II

GNU General Public License v2.0

914 stars 60 forks source link

I replce every word in this code after i cloning it :) #875

Closed ghost closed 2 years ago

ghost commented 2 years ago

[x] I've compiled the code locally on my machine, and it builds without errors "There are problems because there something is wrong in the directory here "
[ ] I've launched the game on my machine after making my changes, and I can successfully start a new game from the main menu
[ ] If your changes are only touching documentation or similar files, which have no influence on the behavior of the code, you can ignore this of course.

lethal-guitar commented 2 years ago

Nice, this looks good, and CI is green. I'll merge this later today.

Regarding the errors shown in your screenshot, this is because VSCode can't find the headers of the SDL library (which is a dependency of RigelEngine). I don't use VSCode myself, so I can't help you with setting it up unfortunately. I would suggest compiling the code directly in Visual Studio.

For reference, here's the guide on how to build the code: https://github.com/lethal-guitar/RigelEngine/blob/master/BUILDING.md#windows-builds

ghost commented 2 years ago

@lethal-guitar thank You for helping me sir <3

lethal-guitar commented 2 years ago

@GAbdulWahab merged in https://github.com/lethal-guitar/RigelEngine/commit/cefd3ba58421a51703206be84c564b98b83c87f7. Thanks for your contribution.

One more note: In the future, please create a branch (git checkout -b branch_name) in your local repository, and open a PR from that branch, instead of using the master branch. It makes it much easier for me to merge.

ghost commented 2 years ago

@lethal-guitar ok, thank you sir <3