Mod directories with non-ASCII names aren't displayed correctly

naftalimurgor commented 8 months ago

Hello @lethal-guitar :wave:

How are you doing. Would like to give this a shot. How do we reproduce this this and also never thought of non-ASCII names for files and directories until seeing this.

lethal-guitar commented 8 months ago

Hi @naftalimurgor, doing alright, thanks! Happy to hear you're interested in tackling this 🙂

To reproduce:

Download one of the mods from the list
Place it into <Game data dir>/mods/<name of mod>
Rename the directory to contain some non-ASCII characters, e.g. Täßtîng 東京
Now, when you launch the game and open the mod manager in the options menu, the non-ASCII characters will be displayed as ???? in the UI.

This happens due to the built-in font coming with the Dear ImGui library not having Unicode glyphs. There should be a fair bit of information on how to add Unicode support on the Dear ImGui wiki.

naftalimurgor commented 8 months ago

Hey @lethal-guitar Glad to hear you are doing well! Taking on this. and will submit a PR as soon as things are set up!

naftalimurgor commented 2 months ago

Hello @lethal-guitar :wave:

I hope you are doing great, been quite busy with college and school work.

Regarding this issue, I found out an issue describing similar edge case faced here: https://github.com/ocornut/imgui/issues/565 Hopefully the pointers highlighted in this issue will help resolve this issue

lethal-guitar / RigelEngine

Mod directories with non-ASCII names aren't displayed correctly #895