search

lethal-guitar / RigelEngine

A modern re-implementation of the classic DOS game Duke Nukem II
GNU General Public License v2.0
911 stars 60 forks source link

Rename `PlayerModel` to `PersistentPlayerState` #911

Closed naftalimurgor closed 1 year ago

naftalimurgor commented 1 year ago

summary

  1. Addresses and closes #878
  2. Renames PlayerModel class and types of PlayerModel* to PersistentPlayerState
  3. RenamempPlayerModel -> mpPersistentPlayerState, pPlayerModel -> pPersistentPlayerState
lethal-guitar commented 1 year ago

Thanks a lot for the PR, appreciate it! I'm currently quite busy, so it might take a while until I can check it out. But I'll get to it eventually! 🙂

naftalimurgor commented 1 year ago

Thanks a lot for the PR, appreciate it! I'm currently quite busy, so it might take a while until I can check it out. But I'll get to it eventually! slightly_smiling_face

Welcome @lethal-guitar!, Looking forward to your feedback. I ran into issues with clan-format but it builds and the game runs. Also, being busy is a positive thing :slightly_smiling_face:

naftalimurgor commented 1 year ago

I'll fix the clang format and also,I noticed I didn't do the renaming quite well so I''ll close and reopen the PR once I fix everything