letheanVPN / lthn-app-vpn

Client/Server dVPN
https://www.lt.hn
European Union Public License 1.2
36 stars 16 forks source link

lvmgmt argument `--sdp-server-uri` doesn't work during `--upload-sdp` #142

Closed bodane closed 2 years ago

bodane commented 2 years ago

lvmgmt --sdp-server-uri argument should work when using --upload-sdp to upload an exit node configuration to a self-hosted SDP server. Instead the default SDP continues to be utilised https://sdp.staging.cloud.lethean.io.

Only present workaround appears to be to update source on util.py#L156 and compile, which then means you then don't need this argument since it becomes the default and desired value.

Replicating issue

lvmgmt --sdp-server-uri https://custom-sdp.com --sdp-wallet-address iz5HSgJUWJmax8Hs2TEAacKhKA9LXLLDvc4u7yCV7Lm4iwkgFXTMFBAdtj2mqMpqy7T4BNveDQdW8LBPVxWqy94B2A6sKJXQ7 --upload-sdp
WARNING:lvmgmt:Uploading SDP to server {'sdp': 'https://sdp.staging.cloud.lethean.io/v1'}
INFO:audit:action=UPLOAD,type=SDP,obj=/opt/lthn/etc/sdp.json,
INFO:audit:action=NEED_PAYMENT,type=SDP_WALLET,wallet=iz5HSgJUWJmax8Hs2TEAacKhKA9LXLLDvc4u7yCV7Lm4iwkgFXTMFBAdtj2mqMpqy7T4BNveDQdW8LBPVxWqy94B2A6sKJXQ7,paymentid=EFAA812B358956F93A0E324385C8B44469A99E5A82F2DE327297B25D8C2EE288,
Snider commented 2 years ago

try this

lvmgmt --compatibility v4 --sdp-server-uri https://custom-sdp.com --sdp-wallet-address iz5HSgJUWJmax8Hs2TEAacKhKA9LXLLDvc4u7yCV7Lm4iwkgFXTMFBAdtj2mqMpqy7T4BNveDQdW8LBPVxWqy94B2A6sKJXQ7 --upload-sdp
Snider commented 2 years ago

https://github.com/letheanVPN/lthn-app-vpn/commit/4ce41adea9497e0eba49f10f2375f239e67db780 updated the default to v4 it was v3 where it manually sets that url

bodane commented 2 years ago

worked :)

lvmgmt  --compatibility v4 --sdp-server-uri https://sdp.lt.hn --sdp-wallet-address iz5HSgJUWJmax8Hs2TEAacKhKA9LXLLDvc4u7yCV7Lm4iwkgFXTMFBAdtj2mqMpqy7T4BNveDQdW8LBPVxWqy94B2A6sKJXQ7 --upload-sdp
WARNING:lvmgmt:Uploading SDP to server {'sdp': 'https://sdp.lt.hn/v1'}
INFO:audit:action=UPLOAD,type=SDP,obj=/opt/lthn/etc/sdp.json,
INFO:audit:action=NEED_PAYMENT,type=SDP_WALLET,wallet=iz5HSgJUWJmax8Hs2TEAacKhKA9LXLLDvc4u7yCV7Lm4iwkgFXTMFBAdtj2mqMpqy7T4BNveDQdW8LBPVxWqy94B2A6sKJXQ7,paymentid=EFAA812B358956F93A0E324385C8B44469A99E5A82F2DE327297B25D8C2EE288,
bodane commented 2 years ago

didn't need the --sdp-wallet-address argument, just testing it works, which it did once executed.