Open dschneiderch opened 4 years ago
Thanks for reporting, I can reproduce that.
The signature has the right type:
https://github.com/letmaik/lensfunpy/blob/a16273a5488c9124cf5f035092cae031df213933/lensfunpy/_lensfun.pyx#L814
I would have thought Cython adds relevant checks to reject any objects that are not Lens
...
EDIT: According to https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#extension-types-and-none it should check the type.
a small usability improvement suggestion. I was consistently getting a segfault error at
initialize
with the code below because I forgot to include the[0]
indexing forlens
. It would make sense to check that lens is of typelensfunpy._lensfun.Lens
and cam is of typelensfunpy._lensfun.Camera