search

letmaik / pyvirtualcam

🎥 Send frames to a virtual camera from Python
GNU General Public License v2.0
472 stars 50 forks source link

linux: start function interface fix #35

Closed Jaiaid closed 3 years ago

Jaiaid commented 3 years ago

Thank you for your repo. It is helpful.

I was checking the repository in my environment. Ubuntu 18.04.05 LTS, python3.6.9, pybind11-2.6.2, gcc 7.5.0

I faced test failure using the provided test files in master branch. Failure screenshot attached. test_summary

This happened due to mismatch of main.cpp's start function interface and NativeCameraBackend's _native.start calling difference error

I have seen that you have solved it in linux-ci branch by changing camera.py code but I think if we don't provide the delay variable, it can be solved without camera.py change and in same branch and this delay variable is not used by any code. What is the purpose of delay? Am I right that you have used, (void)delay; to try to solve this

I have tested the change using provided test code. It has passed with 1 warnings. passed

Jaiaid commented 3 years ago

It seems MacOS build has failed in test_fps_counter

letmaik commented 3 years ago

Thanks for the fix! I missed that, mostly because CI doesn't run tests on Linux currently, see also this note: https://github.com/letmaik/pyvirtualcam/blob/f242953344ea0d4a88545f7c334d3a1755935dcb/.github/scripts/build-linux.sh#L45-L56

Jaiaid commented 3 years ago

Thank you